Re: [PATCH v2] ppp: Move PFC decompression to PPP generic layer
From: David Miller
Date: Thu Dec 20 2018 - 19:49:58 EST
From: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
Date: Thu, 20 Dec 2018 20:29:20 +0200
> Extract "Protocol" field decompression code from transport protocols to
> PPP generic layer, where it actually belongs. As a consequence, this
> patch fixes incorrect place of PFC decompression in L2TP driver (when
> it's not PPPOX_BOUND) and also enables this decompression for other
> protocols, like PPPoE.
> Protocol field decompression also happens in PPP Multilink Protocol
> code and in PPP compression protocols implementations (bsd, deflate,
> mppe). It looks like there is no easy way to get rid of that, so it was
> decided to leave it as is, but provide those cases with appropriate
> comments instead.
> Signed-off-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
> Changes in v2:
> - Fix the order of checking skb data room and proto decompression
> - Remove "inline" keyword from ppp_decompress_proto()
> - Don't split line before function name
> - Prefix ppp_decompress_proto() function with "__"
> - Add ppp_decompress_proto() function with skb data room checks
> - Add description for introduced functions
> - Fix comments (as per review on mailing list)
Applied with Guillaume's suggested adjustments made.