[PATCH RESEND v8 0/2] mtd: rawnand: meson: add Amlogic NAND driver support
From: Jianxin Pan
Date: Fri Dec 21 2018 - 06:46:07 EST
These two patches try to add initial NAND driver support for Amlogic Meson
SoCs, current it has been tested on GXL(p212) and AXG(s400) platform.
Changes since V6 at [8]
- fix bitflips checking for blank pages
- trace the latest commit with nand/next branch
- checking the return of meson_nand_op_get_dma_safe_*input/output*_buf
- add .detach_chip for free meson_nand.data_buf/info_buf
Changes since V6 at [7]
- use timings->tBERS_max as the maximum time out, delete NFC_CMD_RB_TIMEOUT
- fix nand_rw_cmd and support small block flash and which row address less than 3
- fix coding style
- replace readl/writel_* with readl/writel_relaxed*
- delete ECC_SET_PROTECTED_OOB_BYTE and ECC_GET_PROTECTED_OOB_BYTE
- implement dma access for read_buf and write_buf, more efficient.
- delete waiting dma finish in write process and let NAND_CMD_PAGEPROG and
RB command go on queuing
- add waiting the completed flag of last ecc page be set, for more strict
Changes since v5 at [6]:
- use instr->delay_ns in exec_op() to caculate the delay cycle
- delete struct meson_nfc_info_format and use macros instead
- delete "is_scramble" in struct meson_nfc_nand_chip
- add WARN_ON_ONCE() for chip > MAX_CE_NUM
- drop param *mtd* or struct *nfc* if param *nand exist
- substitute set_data_oob and get_data_oob for prase_data_oob and format_data_oob
- split timings caculating and setting timings
- move info_buf and data_buf to struct meson_nfc_nand_chip
Changes since v4 at [5]:
- remove the initial default divider(CLK_DIV_MASK) in meson_nfc_clk_init()
- dt-bindings: remove staus, add "rx" and "tx" clock, and node rename
Changes since v3 at [4]:
- remove partition table and some used props from dt-bindings
Changes since v2 at [3]:
- remove some hardcode time value, like twb
- use dev wait R/B instead of nand_soft_waitrdy
- implement nfc ecc init by ecc helper
- rework nfc buffer init to register the maximun buffer when several chips
- free nfc buffer when error and cleanup
- add variable to teack all the already assigned CS lines
- fix mtd->name use the first cs line only
- remove dt "nand-enable-scrambler" and use NAND_NEED_SCRAMBLING instead.
- move setuping ECC fileds after the identification phase
- use nand_scan() and attach_chip()
- check one event to return IRQ_NONE
- delete cast when of_device_get_match_data
- use nand_controller_init() helper
- remove nfc driver complains when calling devm_ioremap_resource
- clear irqs before setting up irq handler
Changes since v1 at [1]:
- adopt property amlogic,nand-enable-scrambler - thanks Martin
- drop nand pins in DT
- convert clk access to emmc clkc model
- fix regiser field definition alignment
- drop nand-user-mode
- parse cs id from DT
- rework n2m, m2n function
- explain why insert two "IDLE" command
- implement exec_op()
- drop meson_nfc_get_nand_chip_dts()
- release resource once error occur in meson_nfc_nand_chips_init(),
- call nand_cleanup(nand) once mtd_device_register fail
Items not addressed ( or confirmed ) in this version:
- convert to ECC conf helper()
- convert to dma coherent API
- how to construct mtd->name
[1] https://lkml.kernel.org/r/20180613161314.14894-1-yixun.lan@xxxxxxxxxxx
[2] https://lkml.kernel.org/r/20180712211244.11428-1-yixun.lan@xxxxxxxxxxx
[3] https://lkml.kernel.org/r/20180719094612.5833-1-yixun.lan@xxxxxxxxxxx
[4] https://lkml.kernel.org/r/1536317831-58056-1-git-send-email-jianxin.pan@xxxxxxxxxxx/
[5] https://lore.kernel.org/r/1537433449-65213-2-git-send-email-jianxin.pan@xxxxxxxxxxx/
[6] https://lore.kernel.org/r/1539839345-14021-1-git-send-email-jianxin.pan@xxxxxxxxxxx
[7] https://lore.kernel.org/r/1541090542-19618-1-git-send-email-jianxin.pan@xxxxxxxxxxx
[8] http://lkml.kernel.org/r/1542386439-30166-1-git-send-email-jianxin.pan@xxxxxxxxxxx
Liang Yang (2):
dt-bindings: nand: meson: add Amlogic NAND controller driver
mtd: rawnand: meson: add support for Amlogic NAND flash controller
.../devicetree/bindings/mtd/amlogic,meson-nand.txt | 60 +
drivers/mtd/nand/raw/Kconfig | 10 +
drivers/mtd/nand/raw/Makefile | 1 +
drivers/mtd/nand/raw/meson_nand.c | 1468 ++++++++++++++++++++
4 files changed, 1539 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
create mode 100644 drivers/mtd/nand/raw/meson_nand.c
--
1.9.1