Re: [v2] powerpc/32: Move the old 6xx -mcpu logic before the TARGET_CPU logic
From: Michael Ellerman
Date: Sat Dec 22 2018 - 12:01:11 EST
On Wed, 2018-12-05 at 17:53:55 UTC, Mathieu Malaterre wrote:
> The code:
>
> ifdef CONFIG_6xx
> KBUILD_CFLAGS += -mcpu=powerpc
> endif
>
> was added in 2006 in commit f48b8296b315 ("[PATCH] powerpc32: Set cpu
> explicitly in kernel compiles"). This change was acceptable since the
> TARGET_CPU logic was 64-bit only.
>
> Since commit 0e00a8c9fd92 ("powerpc: Allow CPU selection
> also on PPC32") this logic is no longer acceptable after the TARGET_CPU
> specific. It currently appends -mcpu=powerpc at the end of the command
> line, after any TARGET_CPU specific:
>
> gcc -Wp,-MD,init/.do_mounts.o.d ...
> -mcpu=powerpc -mbig-endian -m32 ...
> -mcpu=e300c2 ...
> -mcpu=powerpc ...
> ../init/do_mounts.c
>
> Cc: Christophe Leroy <christophe.leroy@xxxxxx>
> Fixes: 0e00a8c9fd92 ("powerpc: Allow CPU selection also on PPC32")
> Suggested-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> Link: https://www.mail-archive.com/linuxppc-dev@xxxxxxxxxxxxxxxx/msg142315.html
> Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/ebd1d3b74f8542a8f3bb80b453692d
cheers