Re: [PATCH v8 03/26] dt-bindings: Add doc for the Ingenic TCU drivers

From: Paul Cercueil
Date: Sat Dec 22 2018 - 12:07:58 EST




Le mar. 18 déc. 2018 à 17:36, Rob Herring <robh@xxxxxxxxxx> a écrit :
On Mon, Dec 17, 2018 at 4:04 PM Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote:

Hi Rob,

Le lun. 17 déc. 2018 à 22:05, Rob Herring <robh@xxxxxxxxxx> a écrit :
> On Wed, Dec 12, 2018 at 11:08:58PM +0100, Paul Cercueil wrote:
>> Add documentation about how to properly use the Ingenic TCU
>> (Timer/Counter Unit) drivers from devicetree.
>>
>> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
>> ---
>>
>> Notes:
>> v4: New patch in this series. Corresponds to V2 patches 3-4-5
>> with
>> added content.
>>
>> v5: - Edited PWM/watchdog DT bindings documentation to point
>> to the new
>> document.
>> - Moved main document to
>> Documentation/devicetree/bindings/timer/ingenic,tcu.txt
>> - Updated documentation to reflect the new devicetree
>> bindings.
>>
>> v6: - Removed PWM/watchdog documentation files as asked by
>> upstream
>> - Removed doc about properties that should be implicit
>> - Removed doc about ingenic,timer-channel /
>> ingenic,clocksource-channel as they are gone
>> - Fix WDT clock name in the binding doc
>> - Fix lengths of register areas in watchdog/pwm nodes
>>
>> v7: No change
>>
>> v8: - Fix address of the PWM node
>> - Added doc about system timer and clocksource children
>> nodes
>
> I thought we'd sorted this out...

Yeah, well I just can't please everybody. V6/V7 didn't have the
system timer or clocksource in devicetree, which was good for
you, but then the driver nearly doubled in size and complexity,
and Thierry rightfully refused it. Now I'm at the point where

You mean Daniel?

Oops - I meant Daniel yes.

I'm trying alternative ways of encoding the information in
devicetree, as suggested by various people, just so that you
accept it. Because I don't see any other option.

Does the problem boil down to needing to reserve channel x to use PWMx
pin? If so, just do a mask property of reserved for PWM channels.

Yes, that's exactly the problem. I will go with a property then. Thanks!

Sorry this is going in circles.

Rob