Re: [PATCH v2] mfd: tqmx86: IO controller with i2c, wachdog and gpio

[Andrew Lunn]

On Fri, Dec 21, 2018 at 02:35:05PM +0000, Lee Jones wrote:
> > +	if (ioeic_val) {
> > +		tqmx86_writeb(pld, ioeic_val, TQMX86_IOEIC);
> > +		if (tqmx86_readb(pld, TQMX86_IOEIC) != ioeic_val) {
> > +			dev_warn(pld->dev,
> > +				 "i2c/gpio interrupts not supported.\n");
> > +			gpio_irq = 0;
> > +		}
> > +	}
> > +
> > +	if (pld->info.i2c_type == I2C_KIND_SOFT) {
> > +		ocores_platfom_data.clock_khz = pld->pld_clock;
> > +		devs[i++] = tqmx86_devs[TQMX86_I2C_SOFT];
> > +	}
> 
> See other drivers to see how they handle optional cells.

Hi Lee

Could you give an example driver i can copy. My grep foo is not
finding anything useful.

Thanks
	Andrew