Re: [PATCH] fs: proc: check status of register_filesystem

[Al Viro]

On Wed, Dec 26, 2018 at 09:18:56AM +0300, Alexey Dobriyan wrote:
> On Tue, Dec 25, 2018 at 09:06:40PM -0600, Kangjie Lu wrote:
> > register_filesystem() could fail. The fix issues an error message if it
> > fails.
> 
> > -	register_filesystem(&proc_fs_type);
> > +	if (register_filesystem(&proc_fs_type))
> > +		pr_err("failed to register the filesystem.\n");
> 
> No, register_filesystem() should do it.

Folks, check when would it fail.  If we have something called "proc"
already registered by the time when proc_root_init() runs... might
as well have been a panic().