Re: [PATCH] clk: kirkwood: fix refcount leak in kirkwood_clk_init()

[Gregory CLEMENT]

Hi Yangtao,
 
 On mer., dÃc. 26 2018, Yangtao Li <tiny.windzz@xxxxxxxxx> wrote:

> The of_find_compatible_node() returns a node pointer with refcount
> incremented, but there is the lack of use of the of_node_put() when
> done. Add the missing of_node_put() to release the refcount.

Reviewed-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>

Thanks,

Gregory

>
> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
> ---
>  drivers/clk/mvebu/kirkwood.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/mvebu/kirkwood.c b/drivers/clk/mvebu/kirkwood.c
> index 6f784167bda4..35af3aa18f1c 100644
> --- a/drivers/clk/mvebu/kirkwood.c
> +++ b/drivers/clk/mvebu/kirkwood.c
> @@ -331,6 +331,8 @@ static void __init kirkwood_clk_init(struct device_node *np)
>  	if (cgnp) {
>  		mvebu_clk_gating_setup(cgnp, kirkwood_gating_desc);
>  		kirkwood_clk_muxing_setup(cgnp, kirkwood_mux_desc);
> +
> +		of_node_put(cgnp);
>  	}
>  }
>  CLK_OF_DECLARE(kirkwood_clk, "marvell,kirkwood-core-clock",
> -- 
> 2.17.0
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com