Re: [PATCH] mm: compaction.c: Propagate return value upstream

From: Matthew Wilcox
Date: Wed Dec 26 2018 - 14:12:19 EST


On Wed, Dec 26, 2018 at 01:07:49PM -0600, Aditya Pakki wrote:
> {
> + return
> proc_dointvec_minmax(table, write, buffer, length, ppos);
> -
> - return 0;

Don't do this. If you're going to return something, it should be on the same
line as the return statement.

ie:

+ return proc_dointvec_minmax(table, write, buffer, length, ppos);