Re: [PATCH] dsa: return error code upstream
From: David Miller
Date: Thu Dec 27 2018 - 20:53:31 EST
From: Florian Fainelli <f.fainelli@xxxxxxxxx>
Date: Thu, 27 Dec 2018 17:06:58 -0800
> Le 12/27/18 à 4:22 PM, David Miller a écrit :
>> From: Kangjie Lu <kjlu@xxxxxxx>
>> Date: Tue, 25 Dec 2018 22:08:18 -0600
>>> Both bcm_sf2_sw_indir_rw and mdiobus_write_nested could fail, so let's
>>> return their error codes upstream.
>>> Signed-off-by: Kangjie Lu <kjlu@xxxxxxx>
>> Applied with Subject line adjusted as per Florian's feedback.
> Thanks, technically bcm_sf2_sw_indir_rw() cannot fail and checking its
> return value in the write (op == 0) case will always lead to returning 0
> anyway. In case this ever changes in the future, we should be more
> future proof with that change anyway.
Ok, thanks for the insight.