Re: [PATCH v2] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards

[Fabio Estevam]

Hi VokÃÄ,

On Tue, Dec 18, 2018 at 12:42 PM VokÃÄ Michal <Michal.Vokac@xxxxxxxxx> wrote:

> +&fec {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_enet>;
> +       phy-mode = "rgmii-id";
> +       phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_HIGH>;

Are you sure this is active high?

The FEC driver ignores the polarity of phy-reset-gpios and it assumes
the GPIO reset as active low.

If it really is active high, then you would need to pass the
"phy-reset-active-high" property.

> +/ {
> +       model = "Y Soft IOTA Draco i.MX6Solo board";
> +       compatible = "ysoft,imx6dl-yapp4-draco", "fsl,imx6dl";
> +
> +       cpus {
> +               /delete-node/ cpu@1;

Is this really needed? We don't usually do this on imx6solo dts board files.

Only one CPU will be brought up online on imx6solo anyway.

> +       };
> +
> +       memory@10000000 {

Need to pass "device_type = "memory";"

> +/ {
> +       model = "Y Soft IOTA Hydra i.MX6DualLite board";
> +       compatible = "ysoft,imx6dl-yapp4-hydra", "fsl,imx6dl";
> +
> +       memory@10000000 {

Need to pass "device_type = "memory";"

> +       memory@10000000 {

Need to pass "device_type = "memory";"