Re: [GIT PULL] sound updates for 4.21

[Linus Torvalds]

On Fri, Dec 28, 2018 at 9:07 AM Takashi Iwai <tiwai@xxxxxxx> wrote:
>
> 1) Whether ASoC driver cannot work with these Dell machines at all

I'm willing to test patches.

Right now, the reason it fails to even load is that "codec_mask" is 0x0001.

And the skl_hda_dsp_generic.c code requires

        // This will be 1 for 0x0001
        codec_count = hweight_long(codec_mask);

        if (codec_count == 1 && codec_mask & IDISP_CODEC_MASK) {
           .. this is ok ..
        } else if (codec_count == 2 && codec_mask & IDISP_CODEC_MASK) {
           .. as is this ..
        } else {
           .. but here we return -EINVAL;
        }

and that basically requires that IDISP_CODEC_MASK be part of
codec_mask. Which it isn't (IDISP_CODEC_MASK is 0x4).

Anyway, as long as the ASoC driver refuses to touch this, the default
pretty much *has* to be the legacy PCI driver.

                Linus