Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

[David Miller]

From: Peng Hao <peng.hao2@xxxxxxxxxx>
Date: Wed, 26 Dec 2018 16:26:29 +0800

> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
> index 839fa77..8ce4921f 100644
> --- a/drivers/net/wan/fsl_ucc_hdlc.c
> +++ b/drivers/net/wan/fsl_ucc_hdlc.c
> @@ -1057,6 +1057,27 @@ static const struct net_device_ops uhdlc_ops = {
>  	.ndo_tx_timeout	= uhdlc_tx_timeout,
>  };
>  
> +static int ucc_get_resource_by_nodename(char *name, struct resource *res)
> +{
 ...
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	return 0;

This assignment to 'res' doesn't do what you think it does.  The caller never
sees the value you compute.