Re: [PATCH 1/1] net-next/hinic:add shutdown callback

From: David Miller
Date: Sat Dec 29 2018 - 00:49:13 EST


From: Xue Chaojing <xuechaojing@xxxxxxxxxx>
Date: Fri, 28 Dec 2018 00:20:40 +0000

> @@ -1106,6 +1106,13 @@ static void hinic_remove(struct pci_dev *pdev)
> dev_info(&pdev->dev, "HiNIC driver - removed\n");
> }
>
> +static void hinic_shutdown(struct pci_dev *pdev)
> +{
> + pci_disable_device(pdev);
> +
> + dev_info(&pdev->dev, "HiNIC driver - shutdown\n");
> +}

I do not think these messages are appropriate. I didn't catch
them before, but I'm not going to let new ones get added.