Re: [PATCH -mmotm] efi: drop kmemleak_ignore() for page allocator
From: Ard Biesheuvel
Date: Sat Dec 29 2018 - 04:18:37 EST
On Fri, 28 Dec 2018 at 04:04, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, 26 Dec 2018 16:31:59 +0100 Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote:
>
> > Please stop sending EFI patches if you can't be bothered to
> > test/reproduce against the EFI tree.
>
> um, sorry, but that's a bit strong. Finding (let alone fixing) a bug
> in EFI is a great contribution (thanks!) and the EFI maintainers are
> perfectly capable of reviewing and testing the proposed fix. Or of
> fixing the bug by other means.
>
Qian did spot some issues recently, which was really helpful. But I
really think that reporting all issues you find against the -mmotm
tree because that happens to be your preferred tree for development is
not the correct approach.
> Let's not beat people up for helping us in a less-than-perfect way, no?
Fair enough. But asking people to ensure that an issue they found
actually exists on the subsystem tree in question is not that much to
ask, is it?