Re: [PATCH] tools headers: move the nolibc header from rcutorture to tools/include/nolibc/
From: Paul E. McKenney
Date: Sat Dec 29 2018 - 13:26:42 EST
On Sat, Dec 29, 2018 at 07:04:53PM +0100, Willy Tarreau wrote:
> As suggested by Ingo, this header file might benefit other tools than
> just rcutorture. For now it's quite limited, but is easy to extend, so
> exposing it into tools/include/nolibc/ will make it much easier to
> adopt by other tools.
>
> The mkinitrd.sh script in rcutorture was updated to use this new location.
>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Willy Tarreau <w@xxxxxx>
Thank you, Willy! I have queued all four of these. Should there
be a MAINTAINERS file entry for the new include/nolibc home for this
library code?
Thanx, Paul
> ---
> tools/{testing/selftests/rcutorture/bin => include/nolibc}/nolibc.h | 0
> tools/testing/selftests/rcutorture/bin/mkinitrd.sh | 4 ++--
> 2 files changed, 2 insertions(+), 2 deletions(-)
> rename tools/{testing/selftests/rcutorture/bin => include/nolibc}/nolibc.h (100%)
>
> diff --git a/tools/testing/selftests/rcutorture/bin/nolibc.h b/tools/include/nolibc/nolibc.h
> similarity index 100%
> rename from tools/testing/selftests/rcutorture/bin/nolibc.h
> rename to tools/include/nolibc/nolibc.h
> diff --git a/tools/testing/selftests/rcutorture/bin/mkinitrd.sh b/tools/testing/selftests/rcutorture/bin/mkinitrd.sh
> index da29839..d93bca1 100755
> --- a/tools/testing/selftests/rcutorture/bin/mkinitrd.sh
> +++ b/tools/testing/selftests/rcutorture/bin/mkinitrd.sh
> @@ -124,8 +124,8 @@ if echo -e "#if __x86_64__||__i386__||__i486__||__i586__||__i686__" \
> | grep -q '^yes'; then
> # architecture supported by nolibc
> ${CROSS_COMPILE}gcc -fno-asynchronous-unwind-tables -fno-ident \
> - -nostdlib -include ../bin/nolibc.h -lgcc -s -static -Os \
> - -o init init.c
> + -nostdlib -include ../../../../include/nolibc/nolibc.h \
> + -lgcc -s -static -Os -o init init.c
> else
> ${CROSS_COMPILE}gcc -s -static -Os -o init init.c
> fi
> --
> 2.9.0
>