Re: [PATCH v2 3/7] drm: rockchip: vop: add rk3066 vop definitions

From: Heiko Stuebner
Date: Sun Dec 30 2018 - 12:22:20 EST

Hi Johan,

Am Samstag, 29. Dezember 2018, 14:33:14 CET schrieb Johan Jonker:
> From: Mark Yao <mark.yao@xxxxxxxxxxxxxx>
> This patch adds the rk3066 VOP definitions.
> The VOP or LCD Controller serves as interface between
> framebuffer memory and a display device (LCD panel or TV set).
> This SOC has two symmetrical LCDC's for a dual panel application.
> A LCDC has 5 display layers.
> Only 3 are used here.
> - Video layer 0 (Win0)
> - Video layer 1 (Win1)
> - OSD layer (Win2)

Patch itself looks good, we'll need to wait a bit to give Rob a chance
to look at the (simple) dt-binding change and I'll drop the paragraph
about the display layers when applying.

Looking at the rk3066-manual, the lcdcs really only have 3 fully usable
layers + the special cursor layer which is right now not really usable in
a drm context, so the above paragraph is misleading, so I'll just drop it.


> Win0 and Win1 are exchangeable.
> Maximum resolution is 1920x1080.
> The LCDC0 output is connected to:
> - LCDC0 IO (without IOMUX)
> - HDMI TX video input
> The LCDC1 output is connected to:
> - LCDC1 IO (with IOMUX)
> - HDMI TX video input
> The HDMI TX input can switch between LCDC0 and LCDC1.
> Signed-off-by: Mark Yao <mark.yao@xxxxxxxxxxxxxx>
> Signed-off-by: Johan Jonker <jbx6244@xxxxxxxxx>