Re: [PATCH 1/2] doc: cgroup: use graphviz code instead of ASCII art

From: Otto Sabart
Date: Sun Dec 30 2018 - 13:57:42 EST



On 30. Dec (Sunday) v 10:40:29 -0700 2018, Jonathan Corbet wrote:
> On Sun, 30 Dec 2018 17:49:45 +0100
> Otto Sabart <ottosabart@xxxxxxxxxx> wrote:
>
> > The graphviz looks better. This patch also fixes multiple build warnings:
> > "WARNING: Block quote ends without a blank line; unexpected unindent."
> >
> > Signed-off-by: Otto Sabart <ottosabart@xxxxxxxxxx>
>
> The graphviz looks better *in some settings*, such as the formatted
> version of the docs. Please remember, though, that we need to preserve
> the readability of the plain-text documents as well, and my own feeling
> is that this patch is a step backward in that regard. I'll defer to
> Tejun on this if he feels otherwise, but my sense is that this is not
> something we want to do.
>
> OTOH fixing the warnings would be a good thing; I think it just needs a
> bit more use of literal blocks. I would gladly accept a patch that did
> just that.

Ok, no problem. I will send another patch which fixes only these
warnings.

Thanks,

Ota

Attachment: signature.asc
Description: PGP signature