Re: [PATCH 2/4] rcutorture/nolibc: fix some poor indentation and alignment

From: Paul E. McKenney
Date: Mon Dec 31 2018 - 14:43:36 EST


On Sat, Dec 29, 2018 at 12:30:33PM -1000, Joey Pabalinas wrote:
> On Sat, Dec 29, 2018 at 07:02:17PM +0100, Willy Tarreau wrote:
> > A few macros had their rightmost backslash misaligned, and the pollfd
> > struct definition resisted the previous code reindent. Nothing else
> > changed.
> >
> > Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Willy Tarreau <w@xxxxxx>
>
> Reviewed-by: Joey Pabalinas <joeypabalinas@xxxxxxxxx>

Applied, thank you both!

Thanx, Paul

> > ---
> > tools/testing/selftests/rcutorture/bin/nolibc.h | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/tools/testing/selftests/rcutorture/bin/nolibc.h b/tools/testing/selftests/rcutorture/bin/nolibc.h
> > index 30bd27b..985364c 100644
> > --- a/tools/testing/selftests/rcutorture/bin/nolibc.h
> > +++ b/tools/testing/selftests/rcutorture/bin/nolibc.h
> > @@ -81,9 +81,9 @@ typedef signed long time_t;
> >
> > /* for poll() */
> > struct pollfd {
> > - int fd;
> > - short int events;
> > - short int revents;
> > + int fd;
> > + short int events;
> > + short int revents;
> > };
> >
> > /* for select() */
> > @@ -239,7 +239,7 @@ struct stat {
> > "syscall\n" \
> > : "=a" (_ret) \
> > : "0"(_num) \
> > - : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> > + : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> > ); \
> > _ret; \
> > })
> > @@ -255,7 +255,7 @@ struct stat {
> > : "=a" (_ret) \
> > : "r"(_arg1), \
> > "0"(_num) \
> > - : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> > + : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> > ); \
> > _ret; \
> > })
> > @@ -272,7 +272,7 @@ struct stat {
> > : "=a" (_ret) \
> > : "r"(_arg1), "r"(_arg2), \
> > "0"(_num) \
> > - : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> > + : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> > ); \
> > _ret; \
> > })
> > @@ -290,7 +290,7 @@ struct stat {
> > : "=a" (_ret) \
> > : "r"(_arg1), "r"(_arg2), "r"(_arg3), \
> > "0"(_num) \
> > - : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> > + : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> > ); \
> > _ret; \
> > })
> > --
> > 2.9.0
> >
>
> --
> Cheers,
> Joey Pabalinas