Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

From: Pierre-Louis Bossart
Date: Mon Dec 31 2018 - 16:42:21 EST

On 12/31/18 2:35 PM, Sinan Kaya wrote:
On Mon, Dec 31, 2018 at 11:29 PM Pierre-Louis Bossart
<pierre-louis.bossart@xxxxxxxxxxxxxxx> wrote:

On 12/31/18 1:35 PM, Sinan Kaya wrote:
On Mon, Dec 31, 2018 at 10:30 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote:
On Mon, Dec 31, 2018 at 8:47 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
I don't have the cover letter or anything for this series, what's going
on with dependencies?
Here is the executive summary:
I have a changeset that separates ACPI from PCI on 4.21. CONFIG_ACPI
used to select PCI. This is no longer true.
You can build an ACPI system without any PCI devices.
So there's no dependency and I can just apply this?
The plan is to apply this patchset via ACPI tree. Need an Acked-by per patch.
Anytime we change the Kconfig settings for audio, we get all kinds of
problems with randconfig and 0day/kbuild due to depend/select issues.
I'd like to give this a spin first, can you share a link to the entire
series? Thanks!

You can find them here

Click related.

Something must be missing, I get compilation errors when PCI is not defined? And I see tons of references to pci stuff in drivers/acpi.

drivers/acpi/reboot.c: In function âacpi_rebootâ:
drivers/acpi/reboot.c:37:10: error: implicit declaration of function âpci_find_busâ; did you mean âpci_find_next_busâ? [-Werror=implicit-function-declaration]
ÂÂ bus0 = pci_find_bus(0, 0);
ÂÂÂÂÂÂÂÂÂ ^~~~~~~~~~~~
ÂÂÂÂÂÂÂÂÂ pci_find_next_bus
drivers/acpi/reboot.c:37:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
ÂÂ bus0 = pci_find_bus(0, 0);
drivers/acpi/reboot.c:45:3: error: implicit declaration of function âpci_bus_write_config_byteâ; did you mean âpci_write_config_byteâ? [-Werror=implicit-function-declaration]
ÂÂ pci_bus_write_config_byte(bus0, devfn,
ÂÂ ^~~~~~~~~~~~~~~~~~~~~~~~~
ÂÂ pci_write_config_byte