Re: [PATCH v5 0/3] Stingray thermal driver support

[Eduardo Valentin]

On Tue, Jan 01, 2019 at 10:04:39PM +0800, Zhang Rui wrote:
> On ä, 2018-12-31 at 14:15 -0800, Florian Fainelli wrote:
> > 
> > On 04/12/2018 19:17, Srinath Mannam wrote:
> > > 
> > > Hi,
> > > 
> > > Could you please provide your feedback to this patch series?
> > Rui or Eduardo can we get either one of you to review the thermal
> > driver
> > parts of this patch series? Why do we constantly have to chase people
> > to
> > respond in this specific subsystem?
> > 
> Eduardo, can you please take a look at this patch series?

Yup, I will take a look.

> 
> thanks,
> rui
> > > 
> > > 
> > > Regards,
> > > Srinath.
> > > On Thu, Nov 8, 2018 at 3:45 AM Florian Fainelli <f.fainelli@xxxxxxx
> > > om> wrote:
> > > > 
> > > > 
> > > > 
> > > > 
> > > > On 10/16/2018 8:11 AM, Srinath Mannam wrote:
> > > > > 
> > > > > These patches adds the stingray thermal driver and its
> > > > > corresponding DT nodes with documentation.
> > > > Can we get feedback from the thermal maintains whether this is
> > > > acceptable or not?
> > > > 
> > > > > 
> > > > > 
> > > > > Changes from v4
> > > > > Â - Addressed Rob Herring comments on DT parameters and
> > > > > ÂÂÂÂthermal driver architecture.
> > > > > Â - Removed brcm,max-crit-temp DT parameter
> > > > > Â - Changed driver to thermal sensor registration model.
> > > > > Â - Added trip DT properties.
> > > > > 
> > > > > Changes from v3
> > > > > Â - Addressed Daniel lezcano comments.
> > > > > Â - Elaborated commit description of thermal driver patch.
> > > > > Â - Added brcm,max-crit-temp DT parameter.
> > > > > 
> > > > > Changes from v2:
> > > > > Â - All stingray TMON DT nodes are combine together into
> > > > > single.
> > > > > ÂÂÂÂTemperature registers are combined into one mem resource.
> > > > > ÂÂÂÂbrcm,tmon-mask parameter has available TMONs mask value.
> > > > > Â - All available TMONs are initialized together in single
> > > > > ÂÂÂÂinstance of driver probe call.
> > > > > 
> > > > > Changes from v1:
> > > > > Â - Fixed auto build sparce warning.
> > > > > 
> > > > > Pramod Kumar (3):
> > > > > Â dt-bindings: thermal: Add binding document for SR thermal
> > > > > Â thermal: broadcom: Add Stingray thermal driver
> > > > > Â arm64: dts: stingray: Add Stingray Thermal DT support.
> > > > > 
> > > > > Â.../bindings/thermal/brcm,sr-thermal.txtÂÂÂÂÂÂÂÂÂÂÂ| 105
> > > > > ++++++++++++++++
> > > > > Â.../arm64/boot/dts/broadcom/stingray/stingray.dtsi |ÂÂ89
> > > > > +++++++++++++
> > > > > Âdrivers/thermal/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ3 +-
> > > > > Âdrivers/thermal/broadcom/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ9 ++
> > > > > Âdrivers/thermal/broadcom/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ1 +
> > > > > Âdrivers/thermal/broadcom/sr-thermal.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 138
> > > > > +++++++++++++++++++++
> > > > > Â6 files changed, 344 insertions(+), 1 deletion(-)
> > > > > Âcreate mode 100644
> > > > > Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
> > > > > Âcreate mode 100644 drivers/thermal/broadcom/sr-thermal.c
> > > > > 
> > > > --
> > > > Florian