Re: [PATCH 2/2] torture.txt: update the list of supported torture types
From: Paul E. McKenney
Date: Tue Jan 01 2019 - 12:55:01 EST
On Tue, Jan 01, 2019 at 10:03:20PM +0800, Junchang Wang wrote:
> Torture types "rcu_bh" and "sched" were removed in commit "c770c82a23".
> The name of torture type "rcu_busted" was changed to "busted" in commit
> "b3c983142d". Two other types, "srcud" and "busted_srcud" were added in
> commits "ca1d51ed98" and "2397d072f7", respectively. This patch updates
> torture.txt accordingly.
> Signed-off-by: Junchang Wang <junchangwang@xxxxxxxxx>
Given that this section of this file duplicates the rcutorture kernel boot
parameters called out in Documentation/admin-guide/kernel-parameters.txt,
perhaps the best way forward is to instead remove this information from
Documentation/RCU/torture.txt in favor of a reference to the information
(with search string) in Documentation/admin-guide/kernel-parameters.txt.
> Documentation/RCU/torture.txt | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
> diff --git a/Documentation/RCU/torture.txt b/Documentation/RCU/torture.txt
> index 55918b5..6395f0b 100644
> --- a/Documentation/RCU/torture.txt
> +++ b/Documentation/RCU/torture.txt
> @@ -155,20 +155,19 @@ torture_type The type of RCU to test, with string values as follows:
> along with expedited, synchronous, and polling
> - "rcu_bh": rcu_read_lock_bh(), rcu_read_unlock_bh(), and
> - call_rcu_bh(), along with expedited and synchronous
> - variants.
> - "rcu_busted": This tests an intentionally incorrect version
> + "busted": This tests an intentionally incorrect version
> of RCU in order to help test rcutorture itself.
> "srcu": srcu_read_lock(), srcu_read_unlock() and
> call_srcu(), along with expedited and
> synchronous variants.
> - "sched": preempt_disable(), preempt_enable(), and
> - call_rcu_sched(), along with expedited,
> - synchronous, and polling variants.
> + "srcud": A second form of srcu that dynamically allocates
> + and frees srcu_struct to test srcu cleanup code path.
> + "busted_srcud": This torture type verifies rcutorture's ability
> + to detect extensions of RCU read-side critical sections
> + that are not handled.
> "tasks": voluntary context switch and call_rcu_tasks(),
> along with expedited and synchronous variants.