Re: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"

From: Larry Finger
Date: Tue Jan 01 2019 - 20:06:35 EST


On 1/1/19 1:31 PM, Michael Straube wrote:

I've tested your patch and it solved the issue. No freezes and dmesg looks good.

I noticed that try_then_request_module() is also used in rtw_wep_encrypt() and
rtw_wep_decrypt(). I guess that also could cause problems?

Yes, I believe it would if anyone is still using WEP. My plan is to get rid of the try_then_request_module() there as well, and for completeness, I plan to restore usage of the lib80211 routines for TKIP as well.

Once I get a chance to test the TKIP and WEP changes, I plan to have a set of 4 patches to switch the driver to using lib80211 routines for all decryption/encryption.

Larry