Re: [PATCH v2 1/2] pci: altera: Add Stratix10 PCIe support

[Tan, Ley Foon]

On Mon, 2018-12-31 at 09:17 -0600, Bjorn Helgaas wrote:
> Run "git log --oneline --follow drivers/pci/controller/pcie-altera.c" 
> and
> make your subject line match in style, phrasing, and capitalization.
> 
> Hint:
> 
> Â ............ pci: altera: Add Stratix10 PCIe support
> Â ef75369a5b9a PCI: altera: Fix platform_get_irq() error handling
> Â bfdbbf0e3c2a PCI: altera: Use size=4 IRQ domain for legacy INTx
> Â 6ab380957838 PCI: altera: Drop pci_fixup_irqs()
> Â 9815791319a0 PCI: altera: Convert PCI scan API to
> pci_scan_root_bus_bridge()
> Â 2a7275a3d867 PCI: altera: Fix TLP_CFG_DW0 for TLP write
> 
> One of these is not like the others.
Okay, will change it.

> 
> On Mon, Dec 31, 2018 at 04:24:52PM +0800, Ley Foon Tan wrote:
> ...
> > 
> > +struct altera_pcie_data {
> > +	int (*tlp_read_pkt)(struct altera_pcie *pcie, u32 *value);
> > +	void (*tlp_write_pkt)(struct altera_pcie *pcie, u32
> > *headers,
> > +			ÂÂÂÂÂÂu32 data, bool align);
> > +	bool (*get_link_status)(struct altera_pcie *pcie);
> > +	int (*rp_read_cfg)(struct altera_pcie *pcie, int where,
> > +			ÂÂÂint size, u32 *value);
> > +	int (*rp_write_cfg)(struct altera_pcie *pcie, u8 bus, int
> > where,
> > +			ÂÂÂÂint size, u32 value);
> > +	bool s10_flag;		/* Stratix 10 */
> This is OK if you only ever have two programming models (the original
> and Stratix 10).ÂÂBut if there's a possibility of more, an int model
> type that can be tested with a switch is more extensible.
> 
> Personally I prefer bitfields over bool in structures, but ultimately
> Lorenzo will take this and I don't know whether he has a preference.
> 
> https://lkml.kernel.org/r/CA+55aFxnePDimkVKVtv3gNmRGcwc8KQ5mHYvUxY8sA
> Qg6yvVYg@xxxxxxxxxxxxxx
> https://lkml.kernel.org/r/CA+55aFzKQ6Pj18TB8p4Yr0M4t+S+BsiHH=BJNmn=76
> -NcjTj-g@xxxxxxxxxxxxxx

Yes, you are right. Will change it to something like "version type".

Regards
Ley Foon