On Thu, Dec 27, 2018 at 06:04:53PM +0800, Jason Wang wrote:
On 2018/12/26 äå11:22, Michael S. Tsirkin wrote:Can one really switch tx napi on and off? How?
On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:Consider the case:
On 2018/12/6 äå6:54, Michael S. Tsirkin wrote:I just went over the patch again and I don't understand this comment.
When use_napi is set, let's enable BQLs. Note: some of the issues areI've played a similar patch several days before. The tricky part is the mode
similar to wifi. It's worth considering whether something similar to
commit 36148c2bbfbe ("mac80211: Adjust TSQ pacing shift") might be
switching between napi and no napi. We should make sure when the packet is
sent and trakced by BQL,Â it should be consumed by BQL as well.
This patch only enabled BQL with tx napi.
Thus there's no mode switching.
What did I miss?
TX NAPI is disabled:
send N packets
turn TX NAPI on:
get tx interrupt
BQL try to consume those packets when lead WARN for dql.
While root can change the napi_tx module parameter, I don't think
that has any effect outside device probe time. What did I miss?