Re: [RFC PATCH 0/2] allow optee to be exposed on ACPI systems

[Sumit Garg]

On Fri, 28 Dec 2018 at 00:31, Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote:
>
> Similar to how OP-TEE is exposed as a pseudo device under /firmware/optee
> on DT systems, permit OP-TEE presence to be exposed via a device object
> in the ACPI namespace. This makes it possible to model the OP-TEE interface
> as a platform device gets instantiated automatically both on DT and ACPI
> systems, and implement the driver as a platform driver that is able to
> use the generic device properties API to access the 'method' attribute
> as well as potential future extensions to the binding that introduce
> new attributes.
>
> What remains to be discussed is how to expose OP-TEE pseudo devices,
> e.g., Sumit's RNG implementation on SynQuacer which we would like to
> bind a Linux driver to.
>
> Cc: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
> Cc: Sumit Garg <sumit.garg@xxxxxxxxxx>
> Cc: Graeme Gregory <graeme.gregory@xxxxxxxxxx>
> Cc: Jerome Forissier <jerome.forissier@xxxxxxxxxx>
>
> Ard Biesheuvel (2):
>   optee: model OP-TEE as a platform device/driver
>   optee: add ACPI support
>
>  drivers/tee/optee/core.c | 94 +++++++++-----------
>  1 file changed, 41 insertions(+), 53 deletions(-)
>

Looks good to me.

Acked-by: Sumit Garg <sumit.garg@xxxxxxxxxx>


> --
> 2.19.2
>