Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

[Rafael J. Wysocki]

On Sun, Dec 30, 2018 at 8:56 PM Sinan Kaya <okaya@xxxxxxxxxx> wrote:
>
> Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
> CONFIG_PCI set but this is not specified anywhere.

IMO it would be better to say

"After commit 5d32a66541c46 (PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set) dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly.  For this reason, add a direct dependency on
CONFIG_PCI to the IOSF_MBI driver."

If you did that, the reviewers would know upfront what this was about
and that might save at least one back-and-forth e-mail exchange in
each case.