Re: [PATCH v3 4/5] drivers: power: suspend: call devfreq suspend/resume
From: Lukasz Luba
Date: Wed Jan 02 2019 - 10:08:49 EST
Hi Rafael,
Gentle ping...
Please take this patch, it got ACK.
The other patches have been taken through MyungJoo's
tree, but this one is actually enabling the feature.
Regards,
Lukasz
On 12/21/18 1:33 AM, MyungJoo Ham wrote:
>> On 2018-12-05 12:05, Lukasz Luba wrote:
>>> Devfreq framework supports suspend of its devices.
>>> Call the the devfreq interface and allow devfreq devices preserve/restore
>>> their states during suspend/resume.
>>>
>>> Suggested-by: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx>
>>> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
>>> Signed-off-by: Lukasz Luba <l.luba@xxxxxxxxxxxxxxxxxxx>
>
> This looks all good to me.
>
> Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
>
>>> ---
>>> drivers/base/power/main.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
>>> index a690fd4..0992e67 100644
>>> --- a/drivers/base/power/main.c
>>> +++ b/drivers/base/power/main.c
>>> @@ -32,6 +32,7 @@
>>> #include <trace/events/power.h>
>>> #include <linux/cpufreq.h>
>>> #include <linux/cpuidle.h>
>>> +#include <linux/devfreq.h>
>>> #include <linux/timer.h>
>>>
>>> #include "../base.h"
>>> @@ -1078,6 +1079,7 @@ void dpm_resume(pm_message_t state)
>>> dpm_show_time(starttime, state, 0, NULL);
>>>
>>> cpufreq_resume();
>>> + devfreq_resume();
>>> trace_suspend_resume(TPS("dpm_resume"), state.event, false);
>>> }
>>>
>>> @@ -1852,6 +1854,7 @@ int dpm_suspend(pm_message_t state)
>>> trace_suspend_resume(TPS("dpm_suspend"), state.event, true);
>>> might_sleep();
>>>
>>> + devfreq_suspend();
>>> cpufreq_suspend();
>>>
>>> mutex_lock(&dpm_list_mtx);
>
>