Re: [PATCH] NFC: fix attrs checks in netlink interface

From: Andrey Konovalov
Date: Wed Jan 02 2019 - 10:30:39 EST


On Mon, Jun 4, 2018 at 6:29 AM Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> wrote:
>
> Hi Andrey,
>
> On Thu, Apr 12, 2018 at 06:56:56PM +0200, Andrey Konovalov wrote:
> > nfc_genl_deactivate_target() relies on the NFC_ATTR_TARGET_INDEX
> > attribute being present, but doesn't check whether it is actually
> > provided by the user. Same goes for nfc_genl_fw_download() and
> > NFC_ATTR_FIRMWARE_NAME.
> >
> > This patch adds appropriate checks.
> >
> > Found with syzkaller.
> >
> > Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
> > ---
> > net/nfc/netlink.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> Thanks, applied to nfc-next.

Hi Samuel,

It's been 6 months and this fix is still not in mainline. Did it get lost?

Thanks!

>
> Cheers,
> Samuel.