Re: [PATCH v3] driver: uio: fix possible memory leak in uio_open

[Xiubo Li]

On 2019/1/3 22:28, liujian wrote:
> Fixes: 57c5f4df0a5a ("uio: fix crash after the device is unregistered")
> Signed-off-by: liujian <liujian56@xxxxxxxxxx>
> ---
> v1->v2:
> rename the "err_infoopen" to "err_idev_info"
> v2->3:
> put the extra info after the "--"

Looks good to me.

Thanks.
BRs


>   drivers/uio/uio.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index 5c10fc7..aab3520 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -496,18 +496,19 @@ static int uio_open(struct inode *inode, struct file *filep)
>   	if (!idev->info) {
>   		mutex_unlock(&idev->info_lock);
>   		ret = -EINVAL;
> -		goto err_alloc_listener;
> +		goto err_idev_info;
>   	}
>   
>   	if (idev->info && idev->info->open)
>   		ret = idev->info->open(idev->info, inode);
>   	mutex_unlock(&idev->info_lock);
>   	if (ret)
> -		goto err_infoopen;
> +		goto err_idev_info;
>   
>   	return 0;
>   
> -err_infoopen:
> +err_idev_info:
> +	filep->private_data = NULL;
>   	kfree(listener);
>   
>   err_alloc_listener: