Re: [PATCH] kbuild: use assignment instead of define ... endef for filechk_* rules

[Heiko Carstens]

On Thu, Jan 03, 2019 at 10:16:54AM +0900, Masahiro Yamada wrote:
> You do not have to use define ... endef for filechk_* rules.
> 
> For simple cases, the use of assignment looks cleaner, IMHO.
> 
> I updated the usage for scripts/Kbuild.include in case somebody
> misunderstands the 'define ... endif' is the requirement.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
> 
>  Kbuild                             |  4 +---
>  Makefile                           |  3 +--
>  arch/s390/kernel/syscalls/Makefile | 12 +++---------
>  arch/s390/tools/Makefile           |  7 ++-----
>  scripts/Kbuild.include             |  8 ++++----
>  scripts/kconfig/Makefile           |  4 +---
>  6 files changed, 12 insertions(+), 26 deletions(-)

For the s390 bits:
Acked-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>