Re: [PATCH v8 05/25] char/nvram: Adopt arch_nvram_ops

[Christoph Hellwig]

> +
> +const struct nvram_ops arch_nvram_ops = {
> +	.read_byte      = nvram_read_byte,
> +	.write_byte     = nvram_write_byte,
> +	.get_size       = nvram_get_size,
> +};
> +EXPORT_SYMBOL(arch_nvram_ops);

I think something this internal should always be EXPORT_SYMBOL_GPL.