Re: [RFC PATCH 2/2] PCI/portdrv Hisilicon PCIe transport layer Port PMU driver.

From: Will Deacon
Date: Thu Jan 03 2019 - 10:44:43 EST


On Tue, Dec 18, 2018 at 10:21:27AM +0000, Jonathan Cameron wrote:
> On Mon, 17 Dec 2018 12:19:15 -0600
> Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> > Agreed. I could imagine a drivers/pci/pmu/ directory sort of like
> > drivers/pci/switch/.
>
> That might work. Mark, Will what do you think? As long as you and Bjorn
> agree I don't think it'll really matter which one is chosen.
>
> driver/pci/pmu/ or drivers/perf/pci ?

I have a slight preference for the latter since the perf interface for
PMU drivers is notoriously subtle and error-prone. Keeping PMU drivers
together can be helpful to spot emerging patterns and makes cross-driver
changes easier to co-ordinate.

However, I'll defer to Bjorn since it's only a minor preference. We'd
obviously loop in linux-pci + Bjorn on any new submissions.

Will