Re: [PATCH] regmap: regmap-irq: silently ignore unsupported type settings

From: Charles Keepax
Date: Thu Jan 03 2019 - 12:27:51 EST


On Thu, Dec 27, 2018 at 10:44:43AM +0200, Matti Vaittinen wrote:
> Do not return error if irq-type setting is requested for
> controlloer which does not support this. This is how
> regmap-irq has previously handled the undupported type
> settings and existing drivers seem to be upset if failure
> is now reported.
>
> Fixes: 1c2928e3e321 ("regmap: regmap-irq/gpio-max77620: add level-irq support")
> Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> ---
>
> Geert reported that 1c2928e3e321 breaks da9063-rtc on the Renesas
> Koelsch board:
>
> https://lore.kernel.org/lkml/20181227075648.GB2461@xxxxxxxxxxxxxxxxxxxxx/T/#m194616cc88d7b4c2a78f7ce07907608fdb64a092
>
> Geert, do you know if anyone vould to test this?
>

Bit late since its already been applied but this patch fixes the
issues I had.

Thanks,
Charles