Re: [PATCH] dma-mapping: remove unused attrs parameter to dma_common_get_sgtable
Date: Fri Jan 04 2019 - 02:26:59 EST
On Fri, Jan 04, 2019 at 01:45:26AM +0000, Huaisheng HS1 Ye wrote:
> From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Sent: Friday, January 04, 2019 1:55 AM
> > On Thu, 3 Jan 2019, Huaisheng Ye wrote:
> > > From: Huaisheng Ye <yehs1@xxxxxxxxxx>
> > >
> > > dma_common_get_sgtable has parameter attrs which is not used at all.
> > > Remove it.
> > >
> > > Signed-off-by: Huaisheng Ye <yehs1@xxxxxxxxxx>
> > Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > FYI the patch doesn't apply cleanly to master.
> Got it, I will rebase it to branch master and resend the patch later.
I think we can skip it. For the next merge window I plan to remove
the fallbacks for get_sgtable and mmap and instead wire everything up
explicitly. And to be a possible method instance it will have to match
the prototype and thus keep the unused argument.