Re: [f2fs-dev] [PATCH 1/2] f2fs: wait on atomic writes to count F2FS_CP_WB_DATA
From: Chao Yu
Date: Fri Jan 04 2019 - 04:32:01 EST
On 2019/1/4 12:20, Jaegeuk Kim wrote:
> Otherwise, we can get wrong counts incurring checkpoint hang.
> IO_W (CP: -24, Data: 24, Flush: ( 0 0 1), Discard: ( 0 0))
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
Good catch! ;)
I can understand this condition, but for other new developer who reads this
commit, it will be a little hard to understand situation here.
How about explaining a little more about problem here, maybe:
Thread A Thread B
type is F2FS_WB_DATA due to file is non-atomic one
type is F2FS_WB_DATA due to file becomes
Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>