[PATCH RFC lora-next 0/5] net: lora: sx130x: USB CDC Picocell Gateway serdev driver via fake DT nodes
From: Andreas FÃrber
Date: Fri Jan 04 2019 - 06:22:24 EST
Following up on a discussion in August 2018  and my ELCE 2018 talk [2, 3],
I have been searching for an easy way to connect kernel network drivers to
a family of cards/adapters that expose a /dev/ttyACMx device today and
with the vendor's reference software would be accessed from userspace.
While a tty obviously works technically, it leaves us with per-vendor forks
of userspace software without a real upstream community (rare code drops).
It also doesn't allow code sharing with in-kernel protocol stacks or with
the SPI and UART based drivers we've already been working on.
One option suggested by Oliver was a line discipline - that would have the
advantage that it could work with virtually any tty, but on the downside
it would not work out-of-the-box and would require some userspace tool to
manually switch the tty into the new mode. Scalability was another concern,
as was duality of ldisc vs. serdev based implementations.
This patchset rather explores the use of Device Tree nodes to load a serdev
driver on top of the cdc-acm driver. By loading a modified cdc-acm module
plus this quickly hacked-together usb driver, I could play with it on 4.20
on an arm based Turris Omnia router with n-fuse mPCIe card, for instance.
I would hope that the shim approach taken here might also work for FTDI
MPSSE based SPI, encountered by Frank. Not with serdev then, of course,
but as pure USB interface/device driver piggy-backing on what exists.
An unsolved problem is that Semtech in version v0.2.1 switched away from
their own VID/PID to a generic STM32 VID/PID (due to Windows drivers...),
with the only distinction in iProduct string that usb_device_id does not
consider for probing. Since I'm reusing the cdc-acm driver, I can't have
it fail in probe, as it would then fail when called from my driver, too.
Various smaller issues are mentioned in the individual commit messages.
This patchset is based on my linux-lora.git lora-next staging branch.
Please consider taking the small usb patch to aid in further evaluating
serdev on cdc-acm and in resolving the remaining issues.
The others are for testing on our staging tree and for discussion.
Have a lot of fun!
Cc: Johan Hovold <johan@xxxxxxxxxx>
Cc: Rob Herring <robh@xxxxxxxxxx>
Cc: Frank Kunz <mailinglists@xxxxxxxxxxxxxxxxx>
Cc: Oliver Neukum <oneukum@xxxxxxxx>
Cc: Andrew Lunn <andrew@xxxxxxx>
Cc: Sebastian Reichel <sre@xxxxxxxxxx>
Andreas FÃrber (5):
net: lora: sx130x: Factor out SPI specific parts
net: lora: sx130x: Prepare storing driver-specific data
net: lora: sx130x: Add PicoCell serdev driver
usb: cdc-acm: Enable serdev support
HACK: net: lora: sx130x: Add PicoCell gateway shim for cdc-acm
drivers/net/lora/Makefile | 4 +
drivers/net/lora/picogw.c | 337 ++++++++++++++++++++++++++++
drivers/net/lora/sx130x.c | 158 ++++++++-----
drivers/net/lora/sx130x_picogw.c | 466 +++++++++++++++++++++++++++++++++++++++
drivers/usb/class/cdc-acm.c | 8 +-
include/linux/lora/sx130x.h | 9 +
6 files changed, 926 insertions(+), 56 deletions(-)
create mode 100644 drivers/net/lora/picogw.c
create mode 100644 drivers/net/lora/sx130x_picogw.c