Re: [PATCH] ASoC: tlv320aic32x4: Kernel OOPS while entering DAPM standby mode
Date: Fri Jan 04 2019 - 11:40:49 EST
On Fri, Jan 04, 2019 at 01:04:21AM +0530, b-ak wrote:
> On Thu, Jan 03, 2019 at 12:45:54PM +0000, Mark Brown wrote:
> > On Wed, Jan 02, 2019 at 10:36:33PM +0530, b-ak wrote:
> > > During the bootup of the kernel, as soon as the DAPM framework kicks in
> > > it pushes the codec into standy mode.
> > >
> > > The existing TVL320AIC32x4 codec driver doesn't prepare the clock in
> > > the probe function.
> > > This leads to an OOPS when the DAPM tries to put it into standy by calling
> > > clk_disable_unprepare()
> > >
> > > This patch fixes that problem.
> > This isn't the best way of fixing this because it makes it look like
> > there's a missing disable in the removal process. What would be better
> > would be to do what other drivers do and check to see what state we're
> > transitioning from before we disable the clock in set_bias_level(). See
> > drivers like wm8903.c for examples.
> Hello Mark,
> I will test the change and update the patch.
I have updated the patch with the changes.