Re: [RESEND PATCH v5] soc/fsl/qe: fix err handling of ucc_of_parse_tdm
From: David Miller
Date: Fri Jan 04 2019 - 15:51:19 EST
From: Peng Hao <peng.hao2@xxxxxxxxxx>
Date: Thu, 3 Jan 2019 01:09:53 +0800
> From: Wen Yang <wen.yang99@xxxxxxxxxx>
> Currently there are some issues with the ucc_of_parse_tdm function:
> 1, a possible null pointer dereference in ucc_of_parse_tdm,
> detected by the semantic patch deref_null.cocci,
> with the following warning:
> drivers/soc/fsl/qe/qe_tdm.c:177:21-24: ERROR: pdev is NULL but dereferenced.
> 2, dev gets modified, so in any case that devm_iounmap() will fail
> even when the new pdev is valid, because the iomap was done with a
> different pdev.
> 3, there is no driver bind with the "fsl,t1040-qe-si" or
> "fsl,t1040-qe-siram" device. So allocating resources using devm_*()
> with these devices won't provide a cleanup path for these resources
> when the caller fails.
> This patch fixes them.
> Suggested-by: Li Yang <leoyang.li@xxxxxxx>
> Suggested-by: Christophe LEROY <christophe.leroy@xxxxxx>
> Signed-off-by: Wen Yang <wen.yang99@xxxxxxxxxx>
> Reviewed-by: Peng Hao <peng.hao2@xxxxxxxxxx>