Re: [PATCH] qcom-scm: Include <linux/err.h> header

[Guenter Roeck]

On Wed, Dec 26, 2018 at 10:06:19AM -0200, Fabio Estevam wrote:
> Since commit e6f6d63ed14c ("drm/msm: add headless gpu device for imx5")
> the DRM_MSM symbol can be selected by SOC_IMX5 causing the following
> error when building imx_v6_v7_defconfig:
> 
> In file included from ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:17:0:
> ../include/linux/qcom_scm.h: In function 'qcom_scm_set_cold_boot_addr':
> ../include/linux/qcom_scm.h:73:10: error: 'ENODEV' undeclared (first use in this function)
>   return -ENODEV;
> 
> Include the <linux/err.h> header file to fix this problem.
> 
> Reported-by: kernelci.org bot <bot@xxxxxxxxxxxx>
> Fixes: e6f6d63ed14c ("drm/msm: add headless gpu device for imx5")
> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Still broken upstream, and the commit window is about to close.
Any chance to send this patch upstream anytime soon ?

Guenter

> ---
>  include/linux/qcom_scm.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h
> index 06996ad4f2bc..ce5a476fd733 100644
> --- a/include/linux/qcom_scm.h
> +++ b/include/linux/qcom_scm.h
> @@ -13,6 +13,7 @@
>  #ifndef __QCOM_SCM_H
>  #define __QCOM_SCM_H
>  
> +#include <linux/err.h>
>  #include <linux/types.h>
>  #include <linux/cpumask.h>
>