Re: [PATCH RFC lora-next 1/4] net: lora: sx125x sx1301: correct style warnings

[Ben Whitten]

Hi Andreas,

On 29/12/2018 09:05, Andreas FÃrber wrote:
> Hi Ben,
>
> Am 19.12.18 um 16:56 schrieb Ben Whitten:
> > Checkpatch highlights some style issues which need to be addressed.
> >
> > Signed-off-by: Ben Whitten <ben.whitten@xxxxxxxxxxxxx>
> > ---
> >   drivers/net/lora/sx125x.c | 20 +++++++++------
> >   drivers/net/lora/sx1301.c | 52 ++++++++++++++++++++++-----------------
> >   drivers/net/lora/sx1301.h |  7 +++---
> >   3 files changed, 45 insertions(+), 34 deletions(-)
>
> Thanks for splitting this off from the functional changes. This will
> need some more explanations and discussion. In particular the comment
> changes look wrong to me. Also please don't butcher code just because
> checkpatch.pl may warn about line length at this early stage.

Yeh they seemed odd but checkpatch doesn't like a /* on a line by its 
self it seems.

> A good catch in there was the unsigned casts, which are no longer
> necessary since the regmap conversion, so we should just squash that
> into the earlier commits.
>
> Note that I used to run checkpatch.pl as git commit hook:
> http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html
> But since some git update that started to break git rebase -i in case of
> false positives (with rebase stopping and on trying to continue commits
> unintentionally getting squashed), so I deactivated it again and don't
> manually check each commit I stage anymore, in favor of slowly
> completing implementations to a working point.

Good to know, I'll avoid running it for the time and drop this from the v2

Thanks!
Ben Whitten