Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

[Jacek Anaszewski]

Hi Pavel,

On 1/4/19 11:07 PM, Pavel Machek wrote:
> Hi!
>
> > But, aside from that hypothetic issue, we need a solution for
> > LEDn_BRIGHTNESS feature of lp5024, i.e. setting color intensity
> > via a single register write. How would you propose to address that?
>
> So they have hardware feature that allows control of 3 LEDs at the
> same time, right?
>
> Actually turris routers (IIRC) have similar feature, but shared for
> all their LEDs.
>
> I'd suggest simply ignoring that feature for now :-).

Why not use brightness file for that?

> We will need to solve RGB leds somehow, hopefully this is solved with
> it.

When? With this attitude we will procrastinate it forever.
It's been almost 3 years since first HSV patches.

I proposed rough design of LED RGB class interface in [0].
If you find it totally flawed, then please spot the problems.
If not, let's improve it and implement.

[0] https://lkml.org/lkml/2019/1/3/550

--
Best regards,
Jacek Anaszewski