Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32
From: JÃlius Milan
Date: Sun Jan 06 2019 - 02:19:20 EST
Thank you for your review Larry
> Before you send V3
Oh, v3 was already sent a few moments before your message.
> Before you send V3, are you sure this is the correct fix? As "frame_type" is
> input as u16, it seems to me that the frame_type member of struct wilc_reg_frame
> should be __le16, not __le32.
Yes, I am confident about it.
The frame_type member of struct wilc_reg_frame contains in some cases
32 bit value
as you can see in function wilc_wlan_cfg_set_wid.
Cast to 32 bits is also safe, due to resultant endianness.