[PATCH 4.20 052/145] Input: atmel_mxt_ts - dont try to free unallocated kernel memory

From: Greg Kroah-Hartman
Date: Mon Jan 07 2019 - 07:37:29 EST

4.20-stable review patch. If anyone has any objections, please let me know.


From: Sanjeev Chugh <sanjeev_chugh@xxxxxxxxxx>

commit 1e3c336ad8f40f88a8961c434640920fe35cc08b upstream.

If the user attempts to update Atmel device with an invalid configuration
cfg file, error handling code is trying to free cfg file memory which is
not allocated yet hence results into kernel crash.

This patch fixes the order of memory free operations.

Signed-off-by: Sanjeev Chugh <sanjeev_chugh@xxxxxxxxxx>
Fixes: a4891f105837 ("Input: atmel_mxt_ts - zero terminate config firmware file")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -1585,10 +1585,10 @@ static int mxt_update_cfg(struct mxt_dat
/* T7 config may have changed */

- kfree(cfg.raw);
+ kfree(cfg.raw);
return ret;