[PATCH 4.20 070/145] ocxl: Fix endiannes bug in ocxl_link_update_pe()

From: Greg Kroah-Hartman
Date: Mon Jan 07 2019 - 07:38:24 EST

4.20-stable review patch. If anyone has any objections, please let me know.


From: Greg Kurz <groug@xxxxxxxx>

commit e1e71e201703500f708bdeaf64660a2a178cb6a0 upstream.

All fields in the PE are big-endian. Use cpu_to_be32() like everywhere
else something is written to the PE. Otherwise a wrong TID will be used
by the NPU. If this TID happens to point to an existing thread sharing
the same mm, it could be woken up by error. This is highly improbable
though. The likely outcome of this is the NPU not finding the target
thread and forcing the AFU into sending an interrupt, which userspace
is supposed to handle anyway.

Fixes: e948e06fc63a ("ocxl: Expose the thread_id needed for wait on POWER9")
Cc: stable@xxxxxxxxxxxxxxx # v4.18
Signed-off-by: Greg Kurz <groug@xxxxxxxx>
Acked-by: Andrew Donnellan <andrew.donnellan@xxxxxxxxxxx>
Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/misc/ocxl/link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/misc/ocxl/link.c
+++ b/drivers/misc/ocxl/link.c
@@ -566,7 +566,7 @@ int ocxl_link_update_pe(void *link_handl


- pe->tid = tid;
+ pe->tid = cpu_to_be32(tid);

* The barrier makes sure the PE is updated