[PATCH 4.19 106/170] ocxl: Fix endiannes bug in read_afu_name()
From: Greg Kroah-Hartman
Date: Mon Jan 07 2019 - 07:58:03 EST
4.19-stable review patch. If anyone has any objections, please let me know.
From: Greg Kurz <groug@xxxxxxxx>
commit 2f07229f02d4c55affccd11a61af4fd4b94dc436 upstream.
The AFU Descriptor Template in the PCI config space has a Name Space
field which is a 24 Byte ASCII character string of descriptive name
space for the AFU. The OCXL driver read the string four characters at
a time with pci_read_config_dword().
This optimization is valid on a little-endian system since this is PCI,
but a big-endian system ends up with each subset of four characters in
This could be fixed by switching to read characters one by one. Another
option is to swap the bytes if we're big-endian.
Go for the latter with le32_to_cpu().
Cc: stable@xxxxxxxxxxxxxxx # v4.16
Signed-off-by: Greg Kurz <groug@xxxxxxxx>
Acked-by: Frederic Barrat <fbarrat@xxxxxxxxxxxxx>
Acked-by: Andrew Donnellan <andrew.donnellan@xxxxxxxxxxx>
Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
drivers/misc/ocxl/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -318,7 +318,7 @@ static int read_afu_name(struct pci_dev
ptr = (u32 *) &afu->name[i];
- *ptr = val;
+ *ptr = le32_to_cpu((__force __le32) val);
afu->name[OCXL_AFU_NAME_SZ - 1] = '\0'; /* play safe */