[PATCH 4.19 145/170] media: imx274: fix stack corruption in imx274_read_reg

From: Greg Kroah-Hartman
Date: Mon Jan 07 2019 - 07:59:34 EST

4.19-stable review patch. If anyone has any objections, please let me know.


From: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>

commit cea8c0077d6cf3a0cea2f18a8e914af78d46b2ff upstream.

imx274_read_reg() takes a u8 pointer ("reg") and casts it to pass it
to regmap_read(), which takes an unsigned int pointer. This results in
a corrupted stack and random crashes.

Fixes: 0985dd306f72 ("media: imx274: V4l2 driver for Sony imx274 CMOS sensor")

Cc: stable@xxxxxxxxxxxxxxx # for 4.15 and up
Signed-off-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>
Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/media/i2c/imx274.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

--- a/drivers/media/i2c/imx274.c
+++ b/drivers/media/i2c/imx274.c
@@ -636,16 +636,19 @@ static int imx274_write_table(struct sti

static inline int imx274_read_reg(struct stimx274 *priv, u16 addr, u8 *val)
+ unsigned int uint_val;
int err;

- err = regmap_read(priv->regmap, addr, (unsigned int *)val);
+ err = regmap_read(priv->regmap, addr, &uint_val);
if (err)
"%s : i2c read failed, addr = %x\n", __func__, addr);
"%s : addr 0x%x, val=0x%x\n", __func__,
- addr, *val);
+ addr, uint_val);
+ *val = uint_val;
return err;