Re: [PATCH 4.9 00/71] 4.9.149-stable review

[Greg Kroah-Hartman]

On Mon, Jan 07, 2019 at 03:54:14PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Jan 07, 2019 at 08:40:56AM -0600, Daniel Díaz wrote:
> > Hello!
> > 
> > On Mon, 7 Jan 2019 at 07:06, Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > This is the start of the stable review cycle for the 4.9.149 release.
> > > There are 71 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > 
> > With 4.9, we get this build error:
> > | /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/fs/ext4/inode.c:
> > In function 'ext4_write_inode':
> > | /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/fs/ext4/inode.c:5018:6:
> > error: implicit declaration of function 'sb_rdonly'
> > [-Werror=implicit-function-declaration]
> > |       sb_rdonly(inode->i_sb))
> > |       ^~~~~~~~~
> > |   CC      drivers/char/virtio_console.o
> > | In file included from
> > /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/include/linux/linkage.h:4:0,
> > |                  from
> > /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/include/linux/fs.h:4,
> > |                  from
> > /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/fs/ext4/inode.c:21:
> > | /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/fs/ext4/inode.c:5021:15:
> > error: implicit declaration of function 'ext4_forced_shutdown'; did
> > you mean 'ext4_force_commit'? [-Werror=implicit-function-declaration]
> > |   if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb))))
> > |                ^
> > | /srv/oe/build/tmp-lkft-glibc/work-shared/am57xx-evm/kernel-source/include/linux/compiler.h:168:42:
> > note: in definition of macro 'unlikely'
> > |  # define unlikely(x) __builtin_expect(!!(x), 0)
> > |                                           ^
> 
> Ugh, wow.  Ok, something is really wrong with my build systems to not
> find this either, let me go see what is up...

Ok, builder problem fixed (my fault, hadn't updated the kernel tree
there...)  Let me run it through that testing before I push out a -rc3
to make sure I really fix all of these issues.

thanks for pointing these out, it must be monday...

greg k-h