Re: [PATCH 8/8] spi: lpspi: add dma mode support

[Mark Brown]

On Mon, Jan 07, 2019 at 07:47:49AM +0000, Clark Wang wrote:

A couple of small nits but otherwise this looks good:

> +	bytes_per_word = fsl_lpspi_bytes_per_word(transfer->bits_per_word);
> +	if (bytes_per_word != 1 && bytes_per_word != 2 && bytes_per_word != 4)
> +		return false;

This would be clearer written as a switch statement.

> @@ -301,12 +352,59 @@ static int fsl_lpspi_set_bitrate(struct fsl_lpspi_data *fsl_lpspi)
>  	writel(scldiv | (scldiv << 8) | ((scldiv >> 1) << 16),
>  					fsl_lpspi->base + IMX7ULP_CCR);
>  
> -	dev_dbg(fsl_lpspi->dev, "perclk=%d, speed=%d, prescale =%d, scldiv=%d\n",
> +	dev_dbg(fsl_lpspi->dev, "perclk=%d, speed=%d, prescale=%d, scldiv=%d\n",
>  		perclk_rate, config.speed_hz, prescale, scldiv);
>  
>  	return 0;
>  }
>  

This looks like an unrelated typo fix, should be a separate patch.

Attachment: signature.asc
Description: PGP signature