Re: [PATCH 1/5 v2] PM / hibernate: Create snapshot keys handler

From: Stephan Mueller
Date: Mon Jan 07 2019 - 10:53:04 EST

Am Montag, 7. Januar 2019, 16:33:27 CET schrieb joeyli:

Hi Herbert,

> > use an official KDF type like SP800-108 or HKDF?
> >
> > You find the counter-KDF according to SP800-108 in security/keys/dh.c
> > (search for functions *kdf*).
> >
> > Or we may start pulling in KDF support into the kernel crypto API via the
> > patches along the line of [1].
> >
> > [1]
> Thanks for your suggestion. I didn't touch any key derivation standard
> before. I will study it.
> But I still want to use my original function currently. Because the same
> logic is also used in trusted key. I will happy to move to SP800-108 or
> HKDF when it's available in kernel.

Would it make sense to polish these mentioned KDF patches and add them to the
kernel crypto API? The sprawl of key derivation logic here and there which
seemingly does not comply to any standard and thus possibly have issues should
be prevented and cleaned up.