Re: [PATCH v2 04/14] drm: make drm_framebuffer.h self contained

[Noralf TrÃnnes]

Den 30.12.2018 18.48, skrev Sam Ravnborg:
> Add forward declaration and pull in include
> file to make drm_framebuffer.h self contained.
> 
> While add it order include files alphabetically.
> 
> The use of TASK_COMM_LEN is the reason for including sched.h.
> I could not see any good way to avoid this dependency,
> and users of drm_framebuffer.comm already use
> TASK_COMM_LEN to check for length etc.

We can't avoid including it, the macro is used here after all.

> 
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
> Cc: Sean Paul <sean@xxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> ---
>  include/drm/drm_framebuffer.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h
> index c94acedfb08e..f639ed527943 100644
> --- a/include/drm/drm_framebuffer.h
> +++ b/include/drm/drm_framebuffer.h
> @@ -23,13 +23,16 @@
>  #ifndef __DRM_FRAMEBUFFER_H__
>  #define __DRM_FRAMEBUFFER_H__
>  
> -#include <linux/list.h>
>  #include <linux/ctype.h>
> +#include <linux/list.h>
> +#include <linux/sched.h>
> +
>  #include <drm/drm_mode_object.h>
>  
>  struct drm_framebuffer;
>  struct drm_file;
>  struct drm_device;
> +struct drm_clip_rect;

I think you can add drm_gem_object to this list.

>  
>  /**
>   * struct drm_framebuffer_funcs - framebuffer hooks
> 

Acked-by: Noralf TrÃnnes <noralf@xxxxxxxxxxx>